lkml.org 
[lkml]   [2021]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 038/152] mm/vmalloc.c: fix potential memory leak
    Date
    From: Miaohe Lin <linmiaohe@huawei.com>

    commit c22ee5284cf58017fa8c6d21d8f8c68159b6faab upstream.

    In VM_MAP_PUT_PAGES case, we should put pages and free array in vfree.
    But we missed to set area->nr_pages in vmap(). So we would fail to put
    pages in __vunmap() because area->nr_pages = 0.

    Link: https://lkml.kernel.org/r/20210107123541.39206-1-linmiaohe@huawei.com
    Fixes: b944afc9d64d ("mm: add a VM_MAP_PUT_PAGES flag for vmap")
    Signed-off-by: Shijie Luo <luoshijie1@huawei.com>
    Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
    Reviewed-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
    Cc: <stable@vger.kernel.org>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    mm/vmalloc.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/mm/vmalloc.c
    +++ b/mm/vmalloc.c
    @@ -2405,8 +2405,10 @@ void *vmap(struct page **pages, unsigned
    return NULL;
    }

    - if (flags & VM_MAP_PUT_PAGES)
    + if (flags & VM_MAP_PUT_PAGES) {
    area->pages = pages;
    + area->nr_pages = count;
    + }
    return area->addr;
    }
    EXPORT_SYMBOL(vmap);

    \
     
     \ /
      Last update: 2021-01-18 12:57    [W:5.293 / U:0.868 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site