lkml.org 
[lkml]   [2021]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 75/76] netfilter: nf_nat: Fix memleak in nf_nat_init
    Date
    From: Dinghao Liu <dinghao.liu@zju.edu.cn>

    commit 869f4fdaf4ca7bb6e0d05caf6fa1108dddc346a7 upstream.

    When register_pernet_subsys() fails, nf_nat_bysource
    should be freed just like when nf_ct_extend_register()
    fails.

    Fixes: 1cd472bf036ca ("netfilter: nf_nat: add nat hook register functions to nf_nat")
    Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
    Acked-by: Florian Westphal <fw@strlen.de>
    Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    net/netfilter/nf_nat_core.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/net/netfilter/nf_nat_core.c
    +++ b/net/netfilter/nf_nat_core.c
    @@ -1174,6 +1174,7 @@ static int __init nf_nat_init(void)
    ret = register_pernet_subsys(&nat_net_ops);
    if (ret < 0) {
    nf_ct_extend_unregister(&nat_extend);
    + kvfree(nf_nat_bysource);
    return ret;
    }


    \
     
     \ /
      Last update: 2021-01-18 12:53    [W:8.301 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site