Messages in this thread | | | Date | Mon, 18 Jan 2021 10:33:54 +0100 | From | Wolfram Sang <> | Subject | Re: [PATCH RFC 2/3] media: i2c: adv7842: remove open coded version of SMBus block read |
| |
Hello Hans,
I hope you are well!
> > The open coded version differs from the one in the core in one way: the > > buffer will be always copied back, even when the transfer failed. It > > looks like it is expected that the sanity check for a correct CRC and > > header will bail out later. > > Nah, it's just a bug. It should have returned and checked the error code, > so your patch does the right thing.
I see. So, I will only update the commit message.
Thanks for the reviews!
All the best,
Wolfram [unhandled content-type:application/pgp-signature] | |