lkml.org 
[lkml]   [2021]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] x86/cpu/zhaoxin: Fix wrong lowercase naming and indent
From
Date
On 19/01/2021 01:25, Isaac Chen wrote:
> This is printed during kernel boot, match it with other supported x86 cpus.
> [ 0.000000] KERNEL supported cpus:
> [ 0.000000] Intel GenuineIntel
> [ 0.000000] AMD AuthenticAMD
> [ 0.000000] Hygon HygonGenuine
> [ 0.000000] Centaur CentaurHauls
> [ 0.000000] zhaoxin Shanghai
>
> Signed-off-by: Isaac Chen <tingyi364@gmail.com>
> ---
> arch/x86/kernel/cpu/zhaoxin.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/zhaoxin.c b/arch/x86/kernel/cpu/zhaoxin.c
> index 05fa4ef63490..f155bbd2aa97 100644
> --- a/arch/x86/kernel/cpu/zhaoxin.c
> +++ b/arch/x86/kernel/cpu/zhaoxin.c
> @@ -120,8 +120,8 @@ zhaoxin_size_cache(struct cpuinfo_x86 *c, unsigned int size)
> #endif
>
> static const struct cpu_dev zhaoxin_cpu_dev = {
> - .c_vendor = "zhaoxin",
> - .c_ident = { " Shanghai " },
> + .c_vendor = "Zhaoxin",

Thanks for this patch.

> + .c_ident = { "Shanghai" },

The Vendor Identification String from CPUID leaf 0x00000000 of Zhaoxin
CPUs is not "Shanghai", ".c_ident = { "Shanghai" }," will cause the
matching of Zhaoxin CPUs fail.
Please do not modify ".c_ident = { " Shanghai " },".

Sincerely,
Tonyw

\
 
 \ /
  Last update: 2021-01-19 03:12    [W:0.058 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site