Messages in this thread | | | From | Linus Torvalds <> | Date | Mon, 18 Jan 2021 13:35:15 -0800 | Subject | Re: Splicing to/from a tty |
| |
On Mon, Jan 18, 2021 at 12:24 PM Linus Torvalds <torvalds@linux-foundation.org> wrote: > > Anybody want to play with this? I'd suggest keeping that "dummy" > parameter around for a while - I did an allmodconfig build with this, > but if there are any architecture-specific non-x86-64 cases I wouldn't > have seen them.
Not architecture-specific, but I did find by some grepping that I missed one line discipline driver: the Siemens R3964.
The reason I missed that is because it's been marked BROKEN in the Kconfig for almost two years, so it didn't show up in my allmodconfig coverage.
But the fact that I found it makes me a bit happier about my patch actually covering all the cases.
My grep exercise failed on the bluetooth hci_ldisc.c pattern, which I feel is because the bluetooth code used the wrong pattern to initialize the 'struct tty_ldisc_ops', so I fixed that up too.
So here's a slightly updated version of that patch, but apart from slightly better coverage - even if it's a driver that is disabled anyway - I'd like to point out that all my previous caveats still apply.
Linus [unhandled content-type:application/octet-stream] | |