Messages in this thread | | | From | Vladimir Oltean <> | Subject | Re: [PATCH net] net: mrp: use stp state as substitute for unimplemented mrp state | Date | Mon, 18 Jan 2021 19:46:33 +0000 |
| |
On Mon, Jan 18, 2021 at 07:56:18PM +0100, Horatiu Vultur wrote: > The reason was to stay away from STP, because you can't run these two > protocols at the same time. Even though in SW, we reuse port's state. > In our driver(which is not upstreamed), we currently implement > SWITCHDEV_ATTR_ID_MRP_PORT_STATE and just call the > SWITCHDEV_ATTR_ID_PORT_STP_STATE.
And isn't Rasmus's approach reasonable, in that it allows unmodified switchdev drivers to offload MRP port states without creating unnecessary code churn?
Also, if it has no in-kernel users, why does it even exist as a switchdev attribute?
| |