Messages in this thread | | | From | Souptick Joarder <> | Date | Sat, 16 Jan 2021 15:09:41 +0530 | Subject | Re: [PATCH] hugetlbfs: remove meaningless variable avoid_reserve |
| |
On Sat, Jan 16, 2021 at 2:57 PM Miaohe Lin <linmiaohe@huawei.com> wrote: > > The variable avoid_reserve is meaningless because we never changed its > value and just passed it to alloc_huge_page(). So remove it to make code > more clear that in hugetlbfs_fallocate, we never avoid reserve when alloc > hugepage yet. > > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Acked-by: Souptick Joarder <jrdr.linux@gmail.com>
> --- > fs/hugetlbfs/inode.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c > index 88751e35e69d..23ad6ed8b75f 100644 > --- a/fs/hugetlbfs/inode.c > +++ b/fs/hugetlbfs/inode.c > @@ -680,7 +680,6 @@ static long hugetlbfs_fallocate(struct file *file, int mode, loff_t offset, > */ > struct page *page; > unsigned long addr; > - int avoid_reserve = 0; > > cond_resched(); > > @@ -717,7 +716,7 @@ static long hugetlbfs_fallocate(struct file *file, int mode, loff_t offset, > } > > /* Allocate page and add to page cache */ > - page = alloc_huge_page(&pseudo_vma, addr, avoid_reserve); > + page = alloc_huge_page(&pseudo_vma, addr, 0); > hugetlb_drop_vma_policy(&pseudo_vma); > if (IS_ERR(page)) { > mutex_unlock(&hugetlb_fault_mutex_table[hash]); > -- > 2.19.1 > >
| |