lkml.org 
[lkml]   [2021]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] libperf tests: Avoid uninitialized variable warning.
Hi Ian,

On Fri, Jan 15, 2021 at 6:23 AM Ian Rogers <irogers@google.com> wrote:
>
> The variable bf is read (for a write call) without being initialized
> triggering a memory sanitizer warning. Use bf in the read and switch the
> write to reading from a string.
>
> Signed-off-by: Ian Rogers <irogers@google.com>

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung

> ---
> tools/lib/perf/tests/test-evlist.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/lib/perf/tests/test-evlist.c b/tools/lib/perf/tests/test-evlist.c
> index 6d8ebe0c2504..1b225fe34a72 100644
> --- a/tools/lib/perf/tests/test-evlist.c
> +++ b/tools/lib/perf/tests/test-evlist.c
> @@ -208,7 +208,6 @@ static int test_mmap_thread(void)
> char path[PATH_MAX];
> int id, err, pid, go_pipe[2];
> union perf_event *event;
> - char bf;
> int count = 0;
>
> snprintf(path, PATH_MAX, "%s/kernel/debug/tracing/events/syscalls/sys_enter_prctl/id",
> @@ -229,6 +228,7 @@ static int test_mmap_thread(void)
> pid = fork();
> if (!pid) {
> int i;
> + char bf;
>
> read(go_pipe[0], &bf, 1);
>
> @@ -266,7 +266,7 @@ static int test_mmap_thread(void)
> perf_evlist__enable(evlist);
>
> /* kick the child and wait for it to finish */
> - write(go_pipe[1], &bf, 1);
> + write(go_pipe[1], "A", 1);
> waitpid(pid, NULL, 0);
>
> /*
> --
> 2.30.0.296.g2bfb1c46d8-goog
>

\
 
 \ /
  Last update: 2021-01-15 08:45    [W:0.037 / U:1.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site