lkml.org 
[lkml]   [2021]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 037/103] nexthop: Fix off-by-one error in error path
    Date
    From: Ido Schimmel <idosch@nvidia.com>

    [ Upstream commit 07e61a979ca4dddb3661f59328b3cd109f6b0070 ]

    A reference was not taken for the current nexthop entry, so do not try
    to put it in the error path.

    Fixes: 430a049190de ("nexthop: Add support for nexthop groups")
    Signed-off-by: Ido Schimmel <idosch@nvidia.com>
    Reviewed-by: Petr Machata <petrm@nvidia.com>
    Reviewed-by: David Ahern <dsahern@kernel.org>
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/ipv4/nexthop.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/net/ipv4/nexthop.c
    +++ b/net/ipv4/nexthop.c
    @@ -1277,7 +1277,7 @@ static struct nexthop *nexthop_create_gr
    return nh;

    out_no_nh:
    - for (; i >= 0; --i)
    + for (i--; i >= 0; --i)
    nexthop_put(nhg->nh_entries[i].nh);

    kfree(nhg->spare);

    \
     
     \ /
      Last update: 2021-01-15 14:11    [W:4.273 / U:0.632 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site