lkml.org 
[lkml]   [2021]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 069/103] dmaengine: milbeaut-xdmac: Fix a resource leak in the error handling path of the probe function
    Date
    From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

    commit d645148cc82ca7fbacaa601414a552184e9c6dd3 upstream.

    'disable_xdmac()' should be called in the error handling path of the
    probe function to undo a previous 'enable_xdmac()' call, as already
    done in the remove function.

    Fixes: a6e9be055d47 ("dmaengine: milbeaut-xdmac: Add XDMAC driver for Milbeaut platforms")
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Link: https://lore.kernel.org/r/20201219132800.183254-1-christophe.jaillet@wanadoo.fr
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/dma/milbeaut-xdmac.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/drivers/dma/milbeaut-xdmac.c
    +++ b/drivers/dma/milbeaut-xdmac.c
    @@ -351,7 +351,7 @@ static int milbeaut_xdmac_probe(struct p

    ret = dma_async_device_register(ddev);
    if (ret)
    - return ret;
    + goto disable_xdmac;

    ret = of_dma_controller_register(dev->of_node,
    of_dma_simple_xlate, mdev);
    @@ -364,6 +364,8 @@ static int milbeaut_xdmac_probe(struct p

    unregister_dmac:
    dma_async_device_unregister(ddev);
    +disable_xdmac:
    + disable_xdmac(mdev);
    return ret;
    }


    \
     
     \ /
      Last update: 2021-01-15 13:41    [W:2.706 / U:0.468 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site