Messages in this thread | | | Subject | Re: [PATCH v4 1/2] arm64: dts: sdm845: add oneplus6/6t devices | From | Konrad Dybcio <> | Date | Fri, 15 Jan 2021 13:28:05 +0100 |
| |
Please move gpio-keys before reserved-memory to keep things sorted.
> + vreg_l25a_3p3: ldo25 { > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3312000>; > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > + }; > + vdda_mipi_dsi0_1p2:
Add a newline between the "};" and "vdda_mipi_dsi0_1p2:" to keep it consistent.
After that, you can add:
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
| |