Messages in this thread | | | Date | Fri, 15 Jan 2021 20:30:22 -0800 | From | Jakub Kicinski <> | Subject | Re: [PATCH v2] hv_netvsc: Add (more) validation for untrusted Hyper-V values |
| |
On Thu, 14 Jan 2021 21:26:28 +0100 Andrea Parri (Microsoft) wrote: > For additional robustness in the face of Hyper-V errors or malicious > behavior, validate all values that originate from packets that Hyper-V > has sent to the guest. Ensure that invalid values cannot cause indexing > off the end of an array, or subvert an existing validation via integer > overflow. Ensure that outgoing packets do not have any leftover guest > memory that has not been zeroed out. > > Reported-by: Juan Vazquez <juvazq@microsoft.com> > Signed-off-by: Andrea Parri (Microsoft) <parri.andrea@gmail.com> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: Alexei Starovoitov <ast@kernel.org> > Cc: Daniel Borkmann <daniel@iogearbox.net> > Cc: Andrii Nakryiko <andrii@kernel.org> > Cc: Martin KaFai Lau <kafai@fb.com> > Cc: Song Liu <songliubraving@fb.com> > Cc: Yonghong Song <yhs@fb.com> > Cc: John Fastabend <john.fastabend@gmail.com> > Cc: KP Singh <kpsingh@kernel.org> > Cc: netdev@vger.kernel.org > Cc: bpf@vger.kernel.org > --- > Applies to 5.11-rc3 (and hyperv-next).
So this is for hyperv-next or should we take it via netdev trees?
> Changes since v1 (Juan Vazquez): > - Improve validation in rndis_set_link_state() and rndis_get_ppi() > - Remove memory/skb leak in netvsc_alloc_recv_skb()
| |