Messages in this thread | | | Subject | Re: [PATCH v2 3/4] staging: hikey9xx: phy-hi3670-usb3.c: hi3670_is_abbclk_seleted() returns bool | From | Joe Perches <> | Date | Thu, 14 Jan 2021 09:56:41 -0800 |
| |
On Thu, 2021-01-14 at 18:35 +0100, Mauro Carvalho Chehab wrote: > Instead of using 1/0 for true/false, change the type to boolean > and change the returned value. [] > diff --git a/drivers/staging/hikey9xx/phy-hi3670-usb3.c b/drivers/staging/hikey9xx/phy-hi3670-usb3.c [] > @@ -326,24 +326,24 @@ static int hi3670_phy_set_params(struct hi3670_priv *priv) > return ret; > } > > -static int hi3670_is_abbclk_seleted(struct hi3670_priv *priv) > +static bool hi3670_is_abbclk_seleted(struct hi3670_priv *priv)
Presumably this should be "selected" not "seleted"
> { > u32 reg; > > if (!priv->sctrl) { > dev_err(priv->dev, "priv->sctrl is null!\n"); > - return 1; > + return true; > } > > if (regmap_read(priv->sctrl, SCTRL_SCDEEPSLEEPED, ®)) { > dev_err(priv->dev, "SCTRL_SCDEEPSLEEPED read failed!\n"); > - return 1; > + return true; > } > > if ((reg & USB_CLK_SELECTED) == 0) > - return 1; > + return true; > > - return 0; > + return false; > }
if (foo) return true; return false;
should generally be consolidated into a single test.
So this is perhaps better as:
return (!(reg & USB_CLK_SELECTED));
But the return value seems backwards.
| |