Messages in this thread | | | Date | Thu, 14 Jan 2021 07:30:11 +0100 | From | Oscar Salvador <> | Subject | Re: [PATCH v4 4/5] mm: Fix page reference leak in soft_offline_page() |
| |
On 2021-01-14 07:18, Dan Williams wrote: > To be honest I dislike the entire flags based scheme for communicating > the fact that page reference obtained by madvise needs to be dropped > later. I'd rather pass a non-NULL 'struct page *' than redo > pfn_to_page() conversions in the leaf functions, but that's a much > larger change.
We tried to remove that flag in the past but for different reasons. I will have another look to see what can be done.
Thanks
-- Oscar Salvador SUSE L3
| |