Messages in this thread Patch in this message | | | Subject | Re: [PATCH V2 11/11] dts: bindings: Document device tree bindings for Arm TRBE | From | Suzuki K Poulose <> | Date | Thu, 14 Jan 2021 10:17:08 +0000 |
| |
Hi Rob
On 1/13/21 3:45 PM, Rob Herring wrote: > On Wed, 13 Jan 2021 09:48:18 +0530, Anshuman Khandual wrote: >> From: Suzuki K Poulose <suzuki.poulose@arm.com> >> >> Document the device tree bindings for Trace Buffer Extension (TRBE). >> >> Cc: Anshuman Khandual <anshuman.khandual@arm.com> >> Cc: Mathieu Poirier <mathieu.poirier@linaro.org> >> Cc: Rob Herring <robh@kernel.org> >> Cc: devicetree@vger.kernel.org >> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> >> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com> >> --- >> Documentation/devicetree/bindings/arm/trbe.yaml | 46 +++++++++++++++++++++++++ >> 1 file changed, 46 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/arm/trbe.yaml >> > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > ./Documentation/devicetree/bindings/arm/trbe.yaml:39:2: [warning] wrong indentation: expected 2 but found 1 (indentation) > > dtschema/dtc warnings/errors:
Thanks for that. I guess Anshuman can fix this up, with the following patch:
diff --git a/Documentation/devicetree/bindings/arm/trbe.yaml b/Documentation/devicetree/bindings/arm/trbe.yaml index 2258595c40dd..24951e02fa58 100644 --- a/Documentation/devicetree/bindings/arm/trbe.yaml +++ b/Documentation/devicetree/bindings/arm/trbe.yaml @@ -36,7 +36,7 @@ additionalProperties: false
examples:
- - | + - | #include <dt-bindings/interrupt-controller/arm-gic.h>
trbe { > > See https://patchwork.ozlabs.org/patch/1425605 > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date:
I did see the warning, but I thought I fixed it. Sorry about that.
Cheers Suzuki
| |