lkml.org 
[lkml]   [2021]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v6 1/2] dt-bindings: input: cros-ec-keyb: Add a new property
From
Date
Quoting Philip Chen (2021-01-14 18:30:30)
> Add a new property `function-row-physmap` to the
> device tree for the custom keyboard top row design.
>
> The property describes the rows/columns of the top row keys
> from left to right.
>
> Signed-off-by: Philip Chen <philipchen@chromium.org>

Reviewed-by: Stephen Boyd <swboyd@chromium.org>

One nit below.

> diff --git a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
> index 8e50c14a9d778..a742b0777ee6d 100644
> --- a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
> +++ b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
> @@ -43,6 +54,18 @@ examples:
> keypad,num-rows = <8>;
> keypad,num-columns = <13>;
> google,needs-ghost-filter;
> + function-row-physmap = <
> + 0x00020000 /* T1 */
> + 0x03020000 /* T2 */
> + 0x02020000 /* T3 */
> + 0x01020000 /* T4 */
> + 0x03040000 /* T5 */
> + 0x02040000 /* T6 */
> + 0x01040000 /* T7 */
> + 0x02090000 /* T8 */
> + 0x01090000 /* T9 */
> + 0x00040000 /* T10 */

Can we include the header file for MATRIX_KEY so we can use the macro
here?

\
 
 \ /
  Last update: 2021-01-15 03:39    [W:0.044 / U:2.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site