lkml.org 
[lkml]   [2021]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] ata: remove redundant error print in rb532_pata_driver_probe
From
Date
Hello!

On 13.01.2021 17:04, Menglong Dong wrote:

[...]
>>> irq = platform_get_irq(pdev, 0);
>>> - if (irq <= 0) {
>>> - dev_err(&pdev->dev, "no IRQ resource found\n");
>>> + if (irq <= 0)
>>> return -ENOENT;
>>
>> This still beaks the probe deferral. :-(
>> But that's another problem...
>>
>> [...]
>>
>> MBR, Sergei
>
> What does this 'MBR' mean? I am a novice~~~

Generally speaking, Master Boot Record. But I also use it to send you My
Best Regards. :-)

> So, is it better to replace 'platform_get_irq' with
> 'platform_get_irq_optional' here?

No. You should stop overriding the result to -ENOENT and pass the result
up the call chain instead. In order to do it, you should only check for (irq < 0).

> --
> Best Regards
> Menglong Dong

MBR, Sergei

\
 
 \ /
  Last update: 2021-01-14 09:33    [W:0.081 / U:0.640 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site