Messages in this thread | | | From | Brendan Higgins <> | Date | Thu, 14 Jan 2021 16:50:58 -0800 | Subject | Re: [PATCH v4 2/3] kunit: tool: fix minor typing issue with None status |
| |
On Thu, Jan 14, 2021 at 4:39 PM Daniel Latypov <dlatypov@google.com> wrote: > > The code to handle aggregating statuses didn't check that the status > actually got set to some non-None value. > Default the value to SUCCESS instead of adding a bunch of `is None` > checks. > > This sorta follows the precedent in commit 3fc48259d525 ("kunit: Don't > fail test suites if one of them is empty"). > > Also slightly simplify the code and add type annotations. > > Signed-off-by: Daniel Latypov <dlatypov@google.com> > Reviewed-by: David Gow <davidgow@google.com>
Reviewed-by: Brendan Higgins <brendanhiggins@google.com> Tested-by: Brendan Higgins <brendanhiggins@google.com>
| |