lkml.org 
[lkml]   [2021]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] perf test: Fix shadow stat test for non-bash shells
On Thu, Jan 14, 2021 at 03:20:22PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Jan 14, 2021 at 02:06:09PM +0900, Namhyung Kim escreveu:
> > It was using some bash-specific features and failed to parse when
> > running with a different shell like below:
> >
> > root@kbl-ppc:~/kbl-ws/perf-dev/lck-9077/acme.tmp/tools/perf# ./perf test 83 -vv
> > 83: perf stat metrics (shadow stat) test :
> > --- start ---
> > test child forked, pid 3922
> > ./tests/shell/stat+shadow_stat.sh: 19: ./tests/shell/stat+shadow_stat.sh: [[: not found
> > ./tests/shell/stat+shadow_stat.sh: 24: ./tests/shell/stat+shadow_stat.sh: [[: not found
> > ./tests/shell/stat+shadow_stat.sh: 30: ./tests/shell/stat+shadow_stat.sh: [[: not found
> > (standard_in) 2: syntax error
> > ./tests/shell/stat+shadow_stat.sh: 36: ./tests/shell/stat+shadow_stat.sh: [[: not found
> > ./tests/shell/stat+shadow_stat.sh: 19: ./tests/shell/stat+shadow_stat.sh: [[: not found
> > ./tests/shell/stat+shadow_stat.sh: 24: ./tests/shell/stat+shadow_stat.sh: [[: not found
> > ./tests/shell/stat+shadow_stat.sh: 30: ./tests/shell/stat+shadow_stat.sh: [[: not found
> > (standard_in) 2: syntax error
> > ./tests/shell/stat+shadow_stat.sh: 36: ./tests/shell/stat+shadow_stat.sh: [[: not found
> > ./tests/shell/stat+shadow_stat.sh: 45: ./tests/shell/stat+shadow_stat.sh: declare: not found
> > test child finished with -1
> > ---- end ----
> > perf stat metrics (shadow stat) test: FAILED!
>
> Jiri provided an Acked-by for v1, Jiri, can I keep it for this v2?

yep, v2 works for me

Acked-by: Jiri Olsa <jolsa@redhat.com>

jitka

\
 
 \ /
  Last update: 2021-01-14 20:05    [W:0.034 / U:0.504 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site