Messages in this thread | | | Date | Wed, 13 Jan 2021 16:51:32 +0530 | From | Vinod Koul <> | Subject | Re: [PATCH] dmaengine: qcom: Always inline gpi_update_reg |
| |
On 12-01-21, 12:12, Nathan Chancellor wrote: > When building with CONFIG_UBSAN_UNSIGNED_OVERFLOW, clang decides not to > inline gpi_update_reg, which causes a linkage failure around __bad_mask: > > ld.lld: error: undefined symbol: __bad_mask > >>> referenced by bitfield.h:119 (include/linux/bitfield.h:119) > >>> dma/qcom/gpi.o:(gpi_update_reg) in archive drivers/built-in.a > >>> referenced by bitfield.h:119 (include/linux/bitfield.h:119) > >>> dma/qcom/gpi.o:(gpi_update_reg) in archive drivers/built-in.a > > If gpi_update_reg is not inlined, the mask value will not be known at > compile time so the check in field_multiplier stays in the final > object file, causing the above linkage failure. Always inline > gpi_update_reg so that this check can never fail.
Applied, thanks
-- ~Vinod
| |