Messages in this thread | | | Subject | Re: [PATCH v2 0/3] PinePhone volume key (LRADC) wakeup support | From | Hans de Goede <> | Date | Wed, 13 Jan 2021 09:14:01 +0100 |
| |
Hi,
On 1/13/21 5:05 AM, Samuel Holland wrote: > This series allows the volume keys on the PinePhone to wake up the > device. As pointed out for v1, wakeup should only be enabled when a > "wakeup-source" property is present, so v2 requires DT and binding > changes in addition to the driver change. > > Changes since v1: > - Add requisite DT binding change > - Only add wakeup capability if "wakeup-source" is present > - Warn but do not error out if setting the wake IRQ fails > - Add "wakeup-source" property to PinePhone device tree > > Ondrej Jirman (1): > input: sun4i-lradc-keys - Add wakup support > > Samuel Holland (2): > dt-bindings: sun4i-a10-lradc-keys: Accept wakeup-source property > arm64: dts: allwinner: pinephone: Support volume key wakeup
Thanks, the entire series looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
| |