lkml.org 
[lkml]   [2021]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v18 3/3] scsi: ufs: Prepare HPB read for cached sub-region
    Hi Daejun,

    On 2021-01-13 09:36, Daejun Park wrote:
    > Hi Can Guo,
    >
    >> > +static void
    >> > +ufshpb_set_hpb_read_to_upiu(struct ufshpb_lu *hpb, struct ufshcd_lrb
    >> > *lrbp,
    >> > + u32 lpn, u64 ppn, unsigned int transfer_len)
    >> > +{
    >> > + unsigned char *cdb = lrbp->ucd_req_ptr->sc.cdb;
    >> > +
    >> > + cdb[0] = UFSHPB_READ;
    >>
    >> You are only replacing opcode in cdb[0], but
    >> ufshcd_add_command_trace()
    >> is
    >> counting on lrbp->cmd->cmnd. This will lead to wrong opcode recorded
    >> by
    >> UFS ftrace.
    >>
    > You're comment is good point for improving this patch. But there is no
    > "case" for HPB read (0xF8) in ufshcd_add_command_trace().
    > So I will add codes to support tracing HPB read command in
    > ufshcd_add_command_trace() on next patch.
    >

    It is not just about ftrace. If HPB READ cmd fails with sense key infos.
    When SCSI layer prints the cmd, it still prints the READ(10) CDB, which
    is
    misleading.

    Thanks,
    Can Guo.

    > Thanks,
    > Daejun

    \
     
     \ /
      Last update: 2021-01-14 05:10    [W:6.478 / U:0.316 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site