lkml.org 
[lkml]   [2021]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] blk: avoid divide-by-zero with zero granularity
I'm sorry, ignore this one.

Li Feng <fengli@smartx.com> 于2021年1月12日周二 下午11:30写道:
>
> If the physical_block_size and io_min is less than a sector, the
> 'granularity >> SECTOR_SHIFT' will be zero.
>
> Signed-off-by: Li Feng <fengli@smartx.com>
> ---
> include/linux/blkdev.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index f94ee3089e01..4d029e95adb4 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -1485,6 +1485,10 @@ static inline int queue_alignment_offset(const struct request_queue *q)
> static inline int queue_limit_alignment_offset(struct queue_limits *lim, sector_t sector)
> {
> unsigned int granularity = max(lim->physical_block_size, lim->io_min);
> + granularity = granularity >> SECTOR_SHIFT;
> + if (!granularity)
> + return 0;
> +
> unsigned int alignment = sector_div(sector, granularity >> SECTOR_SHIFT)
> << SECTOR_SHIFT;
>
> --
> 2.29.2
>

\
 
 \ /
  Last update: 2021-01-12 16:36    [W:0.052 / U:0.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site