lkml.org 
[lkml]   [2021]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] wireless: realtek: Simplify bool comparison
Date
On Tue, 2021-01-12 at 16:39 +0800, YANG LI wrote:
> Fix the following coccicheck warning:
> ./drivers/net/wireless/realtek/rtlwifi/ps.c:803:7-21: WARNING:
> Comparison to bool
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: YANG LI <abaci-bugfix@linux.alibaba.com>
> ---
>  drivers/net/wireless/realtek/rtlwifi/ps.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/ps.c
> b/drivers/net/wireless/realtek/rtlwifi/ps.c
> index f9988225..629c032 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/ps.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/ps.c
> @@ -798,9 +798,9 @@ static void rtl_p2p_noa_ie(struct ieee80211_hw *hw, void
> *data,
>   ie += 3 + noa_len;
>   }
>  
> - if (find_p2p_ie == true) {
> + if (find_p2p_ie) {
>   if ((p2pinfo->p2p_ps_mode > P2P_PS_NONE) &&
> -     (find_p2p_ps_ie == false))
> +     (!find_p2p_ps_ie))
>   rtl_p2p_ps_cmd(hw, P2P_PS_DISABLE);
>   }
>  }

The subject prefix should be "rtlwifi:".
And, I think it's ok to merge this patch with another patch 
("rtlwifi: rtl8821ae: style: Simplify bool comparison").
Because both of them are trivial fixes and belong to rtlwifi.

---
Ping-Ke

\
 
 \ /
  Last update: 2021-01-12 14:30    [W:0.023 / U:0.504 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site