Messages in this thread | | | Subject | Re: [PATCH v2 02/19] scsi: libsas and users: Remove notifier indirection | From | John Garry <> | Date | Tue, 12 Jan 2021 11:36:21 +0000 |
| |
On 12/01/2021 11:06, Ahmed S. Darwish wrote: > From: John Garry<john.garry@huawei.com> > > The LLDDs report events to libsas with .notify_port_event and > .notify_phy_event callbacks. > > These callbacks are fixed and so there is no reason why we cannot call the > functions directly, so do that. > > This neatens the code slightly. > > [a.darwish@linutronix.de: Remove the now unused "sas_ha" local variables] > Signed-off-by: John Garry<john.garry@huawei.com>
Don't forget your signed-off-by :)
> --- > Documentation/scsi/libsas.rst | 4 +-- > drivers/scsi/aic94xx/aic94xx_scb.c | 20 ++++++------- > drivers/scsi/hisi_sas/hisi_sas_main.c | 12 +++----- > drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 3 +- > drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 3 +- > drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 3 +- > drivers/scsi/isci/port.c | 7 ++--- > drivers/scsi/libsas/sas_event.c | 13 +++------ > drivers/scsi/libsas/sas_init.c | 6 ---- > drivers/scsi/libsas/sas_internal.h | 1 - > drivers/scsi/mvsas/mv_sas.c | 14 ++++----- > drivers/scsi/pm8001/pm8001_hwi.c | 40 ++++++++++++-------------- > drivers/scsi/pm8001/pm8001_sas.c | 7 ++--- > drivers/scsi/pm8001/pm80xx_hwi.c | 35 ++++++++++------------ > include/scsi/libsas.h | 7 ++--- > 15 files changed, 69 insertions(+), 106 deletions(-) > > diff --git a/Documentation/scsi/libsas.rst b/Documentation/scsi/libsas.rst > index f9b77c7879db..a183b1d84713 100644 > --- a/Documentation/scsi/libsas.rst > +++ b/Documentation/scsi/libsas.rst > @@ -189,8 +189,8 @@ num_phys > The event interface:: > > /* LLDD calls these to notify the class of an event. */ > - void (*notify_port_event)(struct sas_phy *, enum port_event); > - void (*notify_phy_event)(struct sas_phy *, enum phy_event); > + void sas_notify_port_event(struct sas_phy *, enum port_event); > + void sas_notify_phy_event(struct sas_phy *, enum phy_event); > > When sas_register_ha() returns, those are set and can be > called by the LLDD to notify the SAS layer of such events
Maybe this was missed in the rebase, but I think that this comment can go/be changed at some stage.
Thanks, John
| |