Messages in this thread | | | Subject | Re: [PATCH v2] i2c: tegra-bpmp: ignore DMA safe buffer flag | From | Mikko Perttunen <> | Date | Tue, 12 Jan 2021 12:19:58 +0200 |
| |
On 1/11/21 11:42 PM, Wolfram Sang wrote: > On Mon, Jan 11, 2021 at 05:58:16PM +0200, Mikko Perttunen wrote: >> From: Muhammed Fazal <mfazale@nvidia.com> >> >> Ignore I2C_M_DMA_SAFE flag as it does not make a difference >> for bpmp-i2c, but causes -EINVAL to be returned for valid >> transactions. > > I wonder if bailing out on an unknown flag shouldn't be revisited in > general? I mean this will happen again when a new I2C_M_* flag is > introduced. >
If it's guaranteed that any new flags are optional to handle by the driver, than that is certainly better. I'll post a v3 with that approach.
thanks, Mikko
| |