lkml.org 
[lkml]   [2021]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH V5 3/3] drm/vkms: Add information about module options
    On 01/12, Sumera Priyadarsini wrote:
    > Update vkms documentation to contain usage of `modinfo`
    > command and steps to load vkms with module options enabled.
    >
    > Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
    > ---
    > Documentation/gpu/vkms.rst | 12 ++++++++++++
    > 1 file changed, 12 insertions(+)
    >
    > diff --git a/Documentation/gpu/vkms.rst b/Documentation/gpu/vkms.rst
    > index 9e030c74a82e..2c9b376da5ca 100644
    > --- a/Documentation/gpu/vkms.rst
    > +++ b/Documentation/gpu/vkms.rst
    > @@ -35,6 +35,18 @@ Now, to load the driver, use::
    > On running the lsmod command now, the VKMS driver will appear listed.
    > You can also observe the driver being loaded in the dmesg logs.
    >
    > +The VKMS driver has optional features to simulate different kinds of hardware,
    > +which are exposed as module options. You can use the `modinfo` command
    > +to see the module options for vkms::
    > +
    > + modinfo vkms
    > +
    > +Module options are helpful when testing, and enabling modules
    > +can be done while loading vkms. For example, to load vkms with cursor enabled,
    > +use::
    > +
    > + sudo modprobe vkms enable_cursor=1
    > +

    Hi Sumera,

    Thanks for documenting.

    You forgot to bring Daniel's ack; however, as I also reviewed and lgtm,

    Reviewed-by: Melissa Wen <melissa.srw@gmail.com>

    > To disable the driver, use ::
    >
    > sudo modprobe -r vkms
    > --
    > 2.25.1
    >

    \
     
     \ /
      Last update: 2021-01-12 11:17    [W:4.804 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site