Messages in this thread | | | Subject | Re: [PATCH net-next 0/5] skbuff: introduce skbuff_heads bulking and reusing | From | Edward Cree <> | Date | Tue, 12 Jan 2021 09:54:04 +0000 |
| |
Without wishing to weigh in on whether this caching is a good idea... Wouldn't it be simpler, rather than having two separate "alloc" and "flush" caches, to have a single larger cache, such that whenever it becomes full we bulk flush the top half, and when it's empty we bulk alloc the bottom half? That should mean fewer branches, fewer instructions etc. than having to decide which cache to act upon every time.
-ed
| |