lkml.org 
[lkml]   [2021]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 1/2] scsi: hisi_sas: Remove unnecessary devm_kfree
From
Date
On Tue, 2021-01-12 at 09:03 +0000, John Garry wrote:
> On 11/01/2021 23:10, Bean Huo wrote:
> > From: Bean Huo <beanhuo@micron.com>
> >
> > The memory allocated with devm_kzalloc() is freed automatically
> > no need to explicitly call devm_kfree.
> >
>
> This change is not right - we use devm_kfree() to manually release
> the
> devm-allocated debugfs memories upon memory allocation failure for
> driver debugfs feature during probe. The reason is that we allow the
> driver probe can still continue (for this failure).
>
> Thanks,
> John

yea, I see, probe didn't deal with ENOMEM error. will drop this change.
thanks.

Bean

\
 
 \ /
  Last update: 2021-01-12 10:16    [W:0.040 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site