Messages in this thread | | | Subject | Re: [PATCH v2 1/2] thermal: int340x: Fix unexpected shutdown at critical temperature | From | Daniel Lezcano <> | Date | Mon, 11 Jan 2021 17:43:55 +0100 |
| |
On 11/01/2021 17:18, Kai-Heng Feng wrote: > On Tue, Dec 22, 2020 at 1:23 AM Kai-Heng Feng > <kai.heng.feng@canonical.com> wrote: >> >> We are seeing thermal shutdown on Intel based mobile workstations, the >> shutdown happens during the first trip handle in >> thermal_zone_device_register(): >> kernel: thermal thermal_zone15: critical temperature reached (101 C), shutting down >> >> However, we shouldn't do a thermal shutdown here, since >> 1) We may want to use a dedicated daemon, Intel's thermald in this case, >> to handle thermal shutdown. >> >> 2) For ACPI based system, _CRT doesn't mean shutdown unless it's inside >> ThermalZone namespace. ACPI Spec, 11.4.4 _CRT (Critical Temperature): >> "... If this object it present under a device, the device’s driver >> evaluates this object to determine the device’s critical cooling >> temperature trip point. This value may then be used by the device’s >> driver to program an internal device temperature sensor trip point." >> >> So a "critical trip" here merely means we should take a more aggressive >> cooling method. >> >> As int340x device isn't present under ACPI ThermalZone, override the >> default .critical callback to prevent surprising thermal shutdown. >> >> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> > > A gentle ping...
Applied, they are in the testing branch now. They will be a linux-next in a couple of days.
Thanks -- Daniel
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
| |