Messages in this thread | | | From | Miguel Ojeda <> | Date | Fri, 1 Jan 2021 21:42:21 +0100 | Subject | Re: [PATCH] sh: check return code of request_irq |
| |
On Fri, Jan 1, 2021 at 2:50 PM John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> wrote: > > Verified on my SH-7785LCR board. Boots fine. > > Tested-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Thanks for testing, John!
I think Masahiro was concerned about the error case (I assume you tested the happy path).
In any case, if no maintainer suggests something else, looks good to me (and it is no worse than the status quo unless the `pr_err()` can somehow kill it), so:
Reviewed-by: Miguel Ojeda <ojeda@kernel.org>
Cheers, Miguel
| |