lkml.org 
[lkml]   [2020]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 16/28] wireless: marvell: mwifiex: init: Move 'tos_to_tid_inv' to where it's used
Date
Lee Jones <lee.jones@linaro.org> writes:

> On Mon, 31 Aug 2020, Kalle Valo wrote:
>
>> Lee Jones <lee.jones@linaro.org> wrote:
>>
>> > 'tos_to_tid_inv' is only used in 2 of 17 files it's current being
>> > included into.
>> >
>> > Fixes the following W=1 kernel build warning(s):
>> >
>> > In file included from drivers/net/wireless/marvell/mwifiex/main.c:23:
>> > In file included from drivers/net/wireless/marvell/mwifiex/cmdevt.c:26:
>> > In file included from drivers/net/wireless/marvell/mwifiex/util.c:25:
>> > In file included from drivers/net/wireless/marvell/mwifiex/txrx.c:25:
>> > In file included from drivers/net/wireless/marvell/mwifiex/11n.c:25:
>> > In file included from drivers/net/wireless/marvell/mwifiex/wmm.c:25:
>> > In file included from drivers/net/wireless/marvell/mwifiex/11n_aggr.c:25:
>> > In file included from drivers/net/wireless/marvell/mwifiex/11n_rxreorder.c:25:
>> > In file included from drivers/net/wireless/marvell/mwifiex/join.c:25:
>> > In file included from drivers/net/wireless/marvell/mwifiex/sta_cmd.c:25:
>> > In file included from drivers/net/wireless/marvell/mwifiex/sta_ioctl.c:25:
>> > In file included from drivers/net/wireless/marvell/mwifiex/sta_event.c:25:
>> > In file included from drivers/net/wireless/marvell/mwifiex/uap_txrx.c:23:
>> > In file included from drivers/net/wireless/marvell/mwifiex/sdio.c:27:
>> > In file included from drivers/net/wireless/marvell/mwifiex/sta_tx.c:25:
>> > drivers/net/wireless/marvell/mwifiex/wmm.h:41:17: warning:
>> > ‘tos_to_tid_inv’ defined but not used [-Wunused-const-variable=]
>> > 41 | static const u8 tos_to_tid_inv[] = {
>> >
>> > NB: Snipped for brevity
>> >
>> > Cc: Amitkumar Karwar <amitkarwar@gmail.com>
>> > Cc: Ganapathi Bhat <ganapathi.bhat@nxp.com>
>> > Cc: Xinming Hu <huxinming820@gmail.com>
>> > Cc: Kalle Valo <kvalo@codeaurora.org>
>> > Cc: "David S. Miller" <davem@davemloft.net>
>> > Cc: Jakub Kicinski <kuba@kernel.org>
>> > Cc: linux-wireless@vger.kernel.org
>> > Cc: netdev@vger.kernel.org
>> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
>>
>> The patch creates two duplicate arrays, this makes it worse than it was
>> before.
>
> We have a choice (and you don't like either of them). :)
>
> Either add the variable into the file(s) they are used or tell the
> compiler that it's okay for other files to declare but not used them
> (mark as __maybe_unused).
>
> What is your preferred solution?

Yue already sent a patch for this (at least I think so, not 100% sure if
this is the same case):

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?id=d56ee19a148edaa9972ca12f817e395ba436078b

But that's the solution I like :) There's only one array and it's shared
by all the users.

--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

\
 
 \ /
  Last update: 2020-09-08 19:33    [W:0.075 / U:0.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site