lkml.org 
[lkml]   [2020]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 03/10] mm/memory_hotplug: simplify page offlining
From
Date
On 07.09.20 08:45, Michal Hocko wrote:
> On Fri 04-09-20 12:21:34, Andrew Morton wrote:
>> On Fri, 4 Sep 2020 07:47:45 +0200 David Hildenbrand <david@redhat.com> wrote:
> [...]
>> @@ -1589,9 +1567,7 @@ int __ref offline_pages(unsigned long st
>> reason = "failure to dissolve huge pages";
>> goto failed_removal_isolated;
>> }
>> - /* check again */
>> - ret = walk_system_ram_range(start_pfn, end_pfn - start_pfn,
>> - NULL, check_pages_isolated_cb);
>> +
>> /*
>> * per-cpu pages are drained in start_isolate_page_range, but if
>> * there are still pages that are not free, make sure that we
>> @@ -1604,15 +1580,15 @@ int __ref offline_pages(unsigned long st
>> * because has_unmovable_pages explicitly checks for
>> * PageBuddy on freed pages on other zones.
>> */
>> + ret = test_pages_isolated(start_pfn, end_pfn, MEMORY_OFFLINE);
>> if (ret)
>> drain_all_pages(zone);
>> } while (ret);
>
> Looks ok
>

Agreed, thanks Michal and Andrew.

--
Thanks,

David / dhildenb

\
 
 \ /
  Last update: 2020-09-08 11:11    [W:0.073 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site