Messages in this thread | | | Subject | Re: [PATCH v3 2/2] dt-bindings: leds: Add bindings for MT6360 LED | From | Dan Murphy <> | Date | Tue, 8 Sep 2020 08:55:26 -0500 |
| |
Gene
On 9/7/20 5:27 AM, Gene Chen wrote: > From: Gene Chen <gene_chen@richtek.com> > > Add bindings document for LED support on MT6360 PMIC > > Signed-off-by: Gene Chen <gene_chen@richtek.com> > --- > .../devicetree/bindings/leds/leds-mt6360.yaml | 105 +++++++++++++++++++++ > 1 file changed, 105 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/leds-mt6360.yaml > > diff --git a/Documentation/devicetree/bindings/leds/leds-mt6360.yaml b/Documentation/devicetree/bindings/leds/leds-mt6360.yaml > new file mode 100644 > index 0000000..72914c6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/leds-mt6360.yaml > @@ -0,0 +1,105 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/leds/leds-mt6360.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: LED driver for MT6360 PMIC from MediaTek Integrated. > + > +maintainers: > + - Gene Chen <gene_chen@richtek.com> > + > +description: | > + This module is part of the MT6360 MFD device. > + The LED controller is represented as a sub-node of the PMIC node on > + the device tree. > + This device has six current sinks. > +
A bit of a nitpick but wouldn't the commit message in patch 1/2 be a better description of the hardware then this?
Other wise
Reviewed-by: Dan Murphy <dmurphy@ti.com>
| |