lkml.org 
[lkml]   [2020]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/7] soundwire: bus: use property to set interrupt masks
From
Date
Dne 28. 08. 20 v 8:51 Vinod Koul napsal(a):
> Hi Mark,
>
> On 18-08-20, 22:06, Bard Liao wrote:
>> From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>>
>> Add a slave-level property and program the SCP_INT1_MASK as desired by
>> the codec driver. Since there is no DisCo property this has to be an
>> implementation-specific firmware property or hard-coded in the driver.
>>
>> The only functionality change is that implementation-defined
>> interrupts are no longer set for amplifiers - those interrupts are
>> typically for jack detection or acoustic event detection/hotwording.
>>
>> Tested-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>> Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
>> Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
>> Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
>> ---
>> drivers/soundwire/bus.c | 12 ++++++------
>> include/linux/soundwire/sdw.h | 2 ++
>> sound/soc/codecs/max98373-sdw.c | 3 +++
>> sound/soc/codecs/rt1308-sdw.c | 2 ++
>> sound/soc/codecs/rt5682-sdw.c | 4 ++++
>> sound/soc/codecs/rt700-sdw.c | 4 ++++
>> sound/soc/codecs/rt711-sdw.c | 4 ++++
>> sound/soc/codecs/rt715-sdw.c | 4 ++++
>> sound/soc/codecs/wsa881x.c | 1 +
>
> This touches codecs, can you Ack it please

Mark, could you ack the ASoC change to accept this patch via the soundwire repo?

>
> Ideally this should have been split up to header, the codec updates and
> finally the bus change!

I don't think that the split is ideal in this case. I tested the code and it
looks straight enough.

Acked-by: Jaroslav Kysela <perex@perex.cz>

--
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.

\
 
 \ /
  Last update: 2020-09-08 21:40    [W:0.094 / U:2.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site