Messages in this thread | | | Subject | Re: [BUG]: KVM: arm64: Fix symbol dependency in __hyp_call_panic_nvhe | From | "H. Nikolaus Schaller" <> | Date | Mon, 7 Sep 2020 16:42:02 +0200 |
| |
Hi,
> Am 07.09.2020 um 16:22 schrieb Sasha Levin <sashal@kernel.org>: > > On Mon, Sep 07, 2020 at 03:29:40PM +0200, H. Nikolaus Schaller wrote: >> Hi, >> it seems as if your patch >> >> 34f379956e9d7 ("KVM: arm64: Fix symbol dependency in __hyp_call_panic_nvhe") >> [ Upstream commit b38b298aa4397e2dc74a89b4dd3eac9e59b64c96 ] >> >> fails to compile in v5.8.7 for me (using an aarch64 gcc 4.9 cross-toolchain to try >> to build a kernel for the PinePhone): >> >> CC arch/arm64/kvm/hyp/switch.o - due to target missing >> arch/arm64/kvm/hyp/switch.c: In function 'hyp_panic': >> arch/arm64/kvm/hyp/switch.c:904:2: error: impossible constraint in 'asm' >> asm volatile("ldr %0, =%1" : "=r" (str_va) : "S" (__hyp_panic_string)); >> ^ > > Does upstream build correctly for you?
It is 100% upstream code in arch/arm64, just with a private config. diff --stat arch/arm64 shows only 2 dts and 2 config files. It did compile well with v5.8.5 and just broke after merge v5.8.7.
> >> I can find the commit b38b298aa4397e2dc74a89b4dd3eac9e59b64c96 in upstream >> but not the affected file. There is also "KVM: arm64: Split hyp/switch.c to VHE/nVHE" >> which does a cleanup and rename and v5.9-rc4 compiles fine. > > Right, it got moved around in upstream.
Maybe this has fixed something...
BR and thanks, Nikolaus
| |