| Subject | Re: [PATCH v5 00/80] drm/vc4: Support BCM2711 Display Pipeline | From | Hoegeun Kwon <> | Date | Mon, 7 Sep 2020 20:49:12 +0900 |
| |
Hi Maxime,
On 9/3/20 5:00 PM, Maxime Ripard wrote: > Hi everyone, > > Here's a (pretty long) series to introduce support in the VC4 DRM driver > for the display pipeline found in the BCM2711 (and thus the RaspberryPi 4). > > The main differences are that there's two HDMI controllers and that there's > more pixelvalve now. Those pixelvalve come with a mux in the HVS that still > have only 3 FIFOs. Both of those differences are breaking a bunch of > expectations in the driver, so we first need a good bunch of cleanup and > reworks to introduce support for the new controllers. > > Similarly, the HDMI controller has all its registers shuffled and split in > multiple controllers now, so we need a bunch of changes to support this as > well. > > Only the HDMI support is enabled for now (even though the DPI and DSI > outputs have been tested too). > > Let me know if you have any comments > Maxime > > Cc: bcm-kernel-feedback-list@broadcom.com > Cc: devicetree@vger.kernel.org > Cc: Kamal Dasu <kdasu.kdev@gmail.com> > Cc: Philipp Zabel <p.zabel@pengutronix.de> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Stephen Boyd <sboyd@kernel.org> > > Changes from v4: > - Rebased on top of next-20200828 > - Collected the various tags > - Fixed some issues with 4k support and dual output (thanks Hoegeun!)
Thanks for your v5 patchset.
I tested all patches based on the next-20200812.
Everything else is fine, but the dual hdmi modetest doesn't work well in my environment...
In my environment, dsi is not connected, I have seen your answer[1].
Do you have any other settings? For example in config.txt.
[1] https://lkml.org/lkml/2020/9/2/566
> - Fixed typos in commit logs (thanks Dave!) > - Split the csc setup hook into its own patch again > - Added the CEC clock to the DT binding > - Fixed the DT binding example > - Reduced the number of calls to of_device_is_compatible in vc4_kms_load > - Added back the check for the state commit in our commit hook
Best regards,
Hoegeun
|