Messages in this thread | | | From | Miquel Raynal <> | Subject | Re: [PATCH v2 1/3] mtd: lpddr: Fix bad logic in print_drs_error | Date | Mon, 7 Sep 2020 09:34:46 +0200 |
| |
On Mon, 2020-04-27 at 19:50:37 UTC, "Gustavo A. R. Silva" wrote: > Update logic for broken test. Use a more common logging style. > > It appears the logic in this function is broken for the > consecutive tests of > > if (prog_status & 0x3) > ... > else if (prog_status & 0x2) > ... > else (prog_status & 0x1) > ... > > Likely the first test should be > > if ((prog_status & 0x3) == 0x3) > > Found by inspection of include files using printk. > > Fixes: eb3db27507f7 ("[MTD] LPDDR PFOW definition") > Cc: stable@vger.kernel.org > Reported-by: Joe Perches <joe@perches.com> > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.
Miquel
| |