Messages in this thread | | | Subject | Re: [PATCH] drm/mediatek: add missing put_device() call in mtk_ddp_comp_init() | From | "yukuai (C)" <> | Date | Tue, 8 Sep 2020 09:05:13 +0800 |
| |
On 2020/09/08 6:56, Chun-Kuang Hu wrote: > Hi Yu Kuai: > > Yu Kuai <yukuai3@huawei.com> 於 2020年9月5日 週六 下午4:31寫道: >> >> if of_find_device_by_node() succeed, mtk_ddp_comp_init() doesn't have >> a corresponding put_device(). Thus add put_device() to fix the exception >> handling for this function implementation. >> > > This patch looks good to me, but I find another thing related to this. > mtk_ddp_comp_init() is called in a loop in mtk_drm_probe(), when this > component init fail, I think we should uninitialize previous > successive init component and put their device. Would you like to make > this patch more complete?
Hi,
Of course, thank you for your review.
Best regards, Yu Kuai
| |