lkml.org 
[lkml]   [2020]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 1/1] Input: atmel_mxt_ts - implement I2C retries
From
Date
05.09.2020 21:02, Andy Shevchenko пишет:
...
>  #define MXT_CRC_TIMEOUT                1000    /* msec */
>  #define MXT_FW_RESET_TIME      3000    /* msec */
>  #define MXT_FW_CHG_TIMEOUT     300     /* msec */
> +#define MXT_WAKEUP_TIME                25      /* msec */
>
>
> Can we simple add _MS unit suffix to the definition?

I'd expect this

>  /* Command to unlock bootloader */
>  #define MXT_UNLOCK_CMD_MSB     0xaa
> @@ -626,6 +627,7 @@ static int __mxt_read_reg(struct i2c_client *client,
>         struct i2c_msg xfer[2];
>         u8 buf[2];
>         int ret;
> +       bool retry = false;
>
>
> Keep this ordered by length.

and this to be separate patches that are cleaning whole driver code,
otherwise there are no much benefits.

\
 
 \ /
  Last update: 2020-09-05 20:57    [W:0.040 / U:1.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site