Messages in this thread | | | From | Linus Torvalds <> | Date | Sat, 5 Sep 2020 10:03:20 -0700 | Subject | Re: [PATCH 2/2] xfs: don't update mtime on COW faults |
| |
On Sat, Sep 5, 2020 at 9:47 AM Linus Torvalds <torvalds@linux-foundation.org> wrote: > > So your patch is obviously correct, [..]
Oh, and I had a xfs pull request in my inbox already, so rather than expect Darrick to do another one just for this and have Jan do one for ext2, I just applied these two directly as "ObviouslyCorrect(tm)".
I added the "inline" as suggested by Darrick, and I also added parenthesis around the bit tests.
Yes, I know the C precedence rules, but I just personally find the code easier to read if I don't even have to think about it and the different subexpressions of a logical operation are just visually very clear. And as I was editing the patch anyway...
So that xfs helper function now looks like this
+static inline bool +xfs_is_write_fault( + struct vm_fault *vmf) +{ + return (vmf->flags & FAULT_FLAG_WRITE) && + (vmf->vma->vm_flags & VM_SHARED); +}
instead.
Linus
| |