lkml.org 
[lkml]   [2020]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [EXT] Re: [PATCH 01/22] mpool: add utility routines and ioctl definitions
Date
Hi Hillf,

On Wednesday, September 30, 2020 5:27 AM, Hillf Danton <hdanton@sina.com> wrote:
> On Mon, 28 Sep 2020 11:45:13 -0500 Nabeel M Mohamed wrote:
> >
> > +/* Rate limited version of mp_pr_err(). */
> > +#define mp_pr_rl(_fmt, _err, ...) \
> > +do { \
> > + static unsigned long mp_pr_rl_state; \
>
> We do not need to declare a mp_pr_rl_state per use case of mp_pr_rl.

Agreed, will make it a global state to rate limit all messages vs. by call site.

>
> > + uint dly = msecs_to_jiffies(333); \
>
> printk_timed_ratelimit() needs msec as input instead of tick.

Nice catch, thanks!

Will address both your comments in v2.

Thanks,
Nabeel

\
 
 \ /
  Last update: 2020-09-30 23:49    [W:1.676 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site