Messages in this thread | | | Date | Thu, 1 Oct 2020 00:02:54 +0300 | From | Jarkko Sakkinen <> | Subject | Re: [PATCH 1/2] certs: Move load_system_certificate_list to a common function |
| |
On Wed, Sep 30, 2020 at 04:15:07PM -0400, Eric Snowberg wrote: > Move functionality within load_system_certificate_list to a common > function, so it can be reused in the future. > > Signed-off-by: Eric Snowberg <eric.snowberg@oracle.com>
I rather think now rather than the future. I think this should be part of a patch set where the re-use actually happens.
Without that context, I rather not say anything about this patch. Neither an issue for me if it gets applied. This is just a guideline that I follow (in order to manage this chaos).
Looking at the code change, I do not see anything strikingly wrong in it.
/Jarkko
| |