lkml.org 
[lkml]   [2020]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 10/22] kvm: mmu: Add TDP MMU PF handler
    From
    Date
    On 30/09/20 18:37, Sean Christopherson wrote:
    >> +
    >> + if (WARN_ON(!VALID_PAGE(vcpu->arch.mmu->root_hpa)))
    >> + return RET_PF_RETRY;
    > I feel like we should kill off these silly WARNs in the existing code instead
    > of adding more. If they actually fired, I'm pretty sure that they would
    > continue firing and spamming the kernel log until the VM is killed as I don't
    > see how restarting the guest will magically fix anything.

    This is true, but I think it's better to be defensive. They're
    certainly all candidates for KVM_BUG_ON.

    Paolo

    \
     
     \ /
      Last update: 2020-09-30 18:55    [W:4.268 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site