| Date | Thu, 3 Sep 2020 15:41:47 -0700 | From | Kees Cook <> | Subject | Re: [PATCH v2 16/28] init: lto: fix PREL32 relocations |
| |
On Thu, Sep 03, 2020 at 01:30:41PM -0700, 'Sami Tolvanen' via Clang Built Linux wrote: > With LTO, the compiler can rename static functions to avoid global > naming collisions. As initcall functions are typically static, > renaming can break references to them in inline assembly. This > change adds a global stub with a stable name for each initcall to > fix the issue when PREL32 relocations are used. > > Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
This was a Delight(tm) to get right. Thanks for finding the right magic here. :)
Reviewed-by: Kees Cook <keescook@chromium.org>
-- Kees Cook
|