| Date | Tue, 29 Sep 2020 14:11:53 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 02/30] spi: dw: Use ternary op to init set_cs callback |
| |
On Sun, Sep 20, 2020 at 02:28:46PM +0300, Serge Semin wrote: > Simplify the dw_spi_add_host() method a bit by replacing the set_cs > callback overwrite procedure with direct setting the callback if a custom > version of one is specified.
> - master->set_cs = dw_spi_set_cs; > + master->set_cs = dws->set_cs ?: dw_spi_set_cs;
> - if (dws->set_cs) > - master->set_cs = dws->set_cs;
This doesn't look like a win for legibility or comprehensibility. [unhandled content-type:application/pgp-signature] |