lkml.org 
[lkml]   [2020]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 342/388] atm: eni: fix the missed pci_disable_device() for eni_init_one()
    Date
    From: Jing Xiangfeng <jingxiangfeng@huawei.com>

    [ Upstream commit c2b947879ca320ac5505c6c29a731ff17da5e805 ]

    eni_init_one() misses to call pci_disable_device() in an error path.
    Jump to err_disable to fix it.

    Fixes: ede58ef28e10 ("atm: remove deprecated use of pci api")
    Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/atm/eni.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/atm/eni.c b/drivers/atm/eni.c
    index 9d0d65efcd94e..bedaebd5a4956 100644
    --- a/drivers/atm/eni.c
    +++ b/drivers/atm/eni.c
    @@ -2245,7 +2245,7 @@ static int eni_init_one(struct pci_dev *pci_dev,

    rc = dma_set_mask_and_coherent(&pci_dev->dev, DMA_BIT_MASK(32));
    if (rc < 0)
    - goto out;
    + goto err_disable;

    rc = -ENOMEM;
    eni_dev = kmalloc(sizeof(struct eni_dev), GFP_KERNEL);
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-09-29 13:57    [W:2.343 / U:0.436 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site