Messages in this thread | | | From | Jani Nikula <> | Subject | Re: [Intel-gfx] [PATCH 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2 | Date | Mon, 28 Sep 2020 20:15:29 +0300 |
| |
On Mon, 28 Sep 2020, "Surendrakumar Upadhyay, TejaskumarX" <tejaskumarx.surendrakumar.upadhyay@intel.com> wrote: > This is a good example of a potential trap that having > IS_ELKHARTLAKE() cover both ELK and JSP creates. An unsuspecting coder > might change the if ladder to have IS_ELKHARTLAKE() first, and the > subsequent IS_JASPERLAKE() branch would never be taken. > > BR, > Jani. > > Tejas : In that case I will put attention note in comment about > platform checks such that ladder distrubance can be avoided. What you > suggest?
The solution is to make IS_ELKHARTLAKE() mean ELK and only ELK.
BR, Jani.
-- Jani Nikula, Intel Open Source Graphics Center
| |