Messages in this thread | | | Date | Mon, 28 Sep 2020 17:50:05 +0200 | From | Miquel Raynal <> | Subject | Re: [PATCH v4 1/2] mtd: spinand: micron: Generalize the function and structure names |
| |
Boris Brezillon <boris.brezillon@collabora.com> wrote on Mon, 28 Sep 2020 17:45:05 +0200:
> On Mon, 28 Sep 2020 16:55:28 +0200 > Miquel Raynal <miquel.raynal@bootlin.com> wrote: > > > > IMHO, grouped means, ecc bytes are at continuous address, where as > > > interleaved means ecc bytes splitted into multiple addresses > > > > I don't like the name. Interleaved means that there are OOB bytes > > stored in the data section, which is not the case here. > > Well, I would argue that the term interleaved alone doesn't say > anything about the things that are interleaved. But I guess
I should have said that interleaved, in this subsystem, generally refers to in-band vs. out-of-band data.
> split/grouped would be fine too if you want to avoid re-using > interleaved here.
split/grouped is fine by me.
> > > The way OOB > > bytes are organized do not seem relevant to me, I think i prefer the > > "_4_/_8_" naming,even if it's not very explicit. > > The ECC strength doesn't say anything about the scheme used for ECC > bytes placement, and you might end up with 2 different schemes > providing the same strength, or the same scheme used for 2 different > strengths.
So perhaps both should be present in the name?
| |