Messages in this thread | | | Date | Mon, 28 Sep 2020 14:53:35 +0100 | From | Lee Jones <> | Subject | Re: [PATCH v6] mfd: intel-m10-bmc: add Intel MAX 10 BMC chip support for Intel FPGA PAC |
| |
On Tue, 15 Sep 2020, Xu Yilun wrote:
> This patch implements the basic functions of the BMC chip for some Intel > FPGA PCIe Acceleration Cards (PAC). The BMC is implemented using the > Intel MAX 10 CPLD. > > This BMC chip is connected to the FPGA by a SPI bus. To provide direct > register access from the FPGA, the "SPI slave to Avalon Master Bridge" > (spi-avmm) IP is integrated in the chip. It converts encoded streams of > bytes from the host to the internal register read/write on the Avalon > bus. So This driver uses the regmap-spi-avmm for register accessing. > > Signed-off-by: Xu Yilun <yilun.xu@intel.com> > Signed-off-by: Wu Hao <hao.wu@intel.com> > Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com> > Signed-off-by: Russ Weight <russell.h.weight@intel.com> > Reviewed-by: Tom Rix <trix@redhat.com> > --- > v2: Split out the regmap-spi-avmm part. > Rename the file intel-m10-bmc-main.c to intel-m10-bmc.c, cause > there is only one source file left for this module now. > v3: Add the sub devices in mfd_cell. > Some minor fixes. > v4: No change. > v5: Changes the names of mfd_cell. > Use ATTRIBUTE_GROUPS() to simplify the code. > Use the generic 'ddata' for the instance of struct intel_m10bmc. > More comments to clarify the function check_m10bmc_version(). > Some minor fixes. > v6: Defines macro for invalid legacy bmc version value to make the > version check more clear. > Add comments for the purpose of abstraction of the regmap ops. > --- > .../ABI/testing/sysfs-driver-intel-m10-bmc | 15 ++ > drivers/mfd/Kconfig | 13 ++ > drivers/mfd/Makefile | 2 + > drivers/mfd/intel-m10-bmc.c | 164 +++++++++++++++++++++ > include/linux/mfd/intel-m10-bmc.h | 65 ++++++++ > 5 files changed, 259 insertions(+) > create mode 100644 Documentation/ABI/testing/sysfs-driver-intel-m10-bmc > create mode 100644 drivers/mfd/intel-m10-bmc.c > create mode 100644 include/linux/mfd/intel-m10-bmc.h
Applied, thanks.
-- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
| |